Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Readers who need to add pages from another PDF have to leave Folio, risking the page order and edits they already prepared.
Change
Select one or more PDFs or drop them on the organizer. Choose the start, end, or either side of the selected page. The thumbnail menu can insert immediately after its selection. Imported pages show their filename and can be moved, rotated, deleted, undone, and redone before saving a separate copy. Insertion is available for unencrypted files. Rotating or deleting pages from a single protected document preserves its protection.
Issue or approval
Final part of #69. This PR builds on rotation in #95 and deletion in #85. Retarget to main after the preceding changes land.
How I checked it
All 259 unit tests, the production build with type checking, and the complete hidden macOS smoke suite passed. The end-to-end checks exercised all four insertion positions, multi-file drop, undo and redo, interleaving pages from two PDFs, and saved text and orientation after reopening the result. They also rejected an encrypted attachment, disabled insertion for an encrypted destination, and confirmed that a rotated AES-256 PDF still required its original password. Screenshots from the run are named organizer-before-insert.png and organizer-after-insert.png.
Implemented with GPT-6 in Codex.